Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder install-app-deps does not honor build.directories.app #1721

Closed
kvnsmth opened this issue Jun 21, 2017 · 1 comment · May be fixed by qcif/data-curator#563
Closed

electron-builder install-app-deps does not honor build.directories.app #1721

kvnsmth opened this issue Jun 21, 2017 · 1 comment · May be fixed by qcif/data-curator#563
Labels

Comments

@kvnsmth
Copy link

kvnsmth commented Jun 21, 2017

  • Version: 19.6.3
  • Target: macOS

The latest electron-builder install-app-deps ignores an override in build.directories.app, ie it always uses app for the directory.

I think this is because of these two lines:

https://github.com/electron-userland/electron-builder/blob/v19.6.3/packages/electron-builder/src/cli/install-app-deps.ts#L42
and
https://github.com/electron-userland/electron-builder/blob/v19.6.3/packages/electron-builder/src/util/config.ts#L59

I would expect getConfig to always call loadConfig but it doesn't when called from installAppDeps (since null is explicitly passed in). @develar I see you on the blame line so maybe you could shed some light on why it skips if packageMetadata == null?

This works as expected on 19.4.2.

@develar develar added the bug label Jun 21, 2017
@develar
Copy link
Member

develar commented Jun 21, 2017

Fixed in 19.7.1, thanks.

todo: add test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants