Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a new file macro matching Node.js "process.platform" property #2652

Closed
lbssousa opened this issue Mar 1, 2018 · 0 comments · May be fixed by qcif/data-curator#563
Closed

Provide a new file macro matching Node.js "process.platform" property #2652

lbssousa opened this issue Mar 1, 2018 · 0 comments · May be fixed by qcif/data-curator#563
Labels
feature

Comments

@lbssousa
Copy link

lbssousa commented Mar 1, 2018

  • Version: 20.2.0
  • Target: Windows

I would like to suggest a new file macro ${platform} that would match the value of Node.js process.platform property (or change ${os} file macro to match it).

It would avoid some little annoyances in Electron entry file, like process.platform === 'win32' ? 'win' : (process.platform === 'darwin' ? 'mac' : process.platform) tests to match ${os} file macro with process.platform property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump electron-builder from 19.55.2 to 20.5.1 qcif/data-curator
2 participants
@develar @lbssousa