Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks for linux homepage in the development package.json not in the application package.json #334

Closed
mcfedr opened this issue Apr 18, 2016 · 2 comments · May be fixed by qcif/data-curator#563

Comments

@mcfedr
Copy link

mcfedr commented Apr 18, 2016

The docs say looks for homepage in application but the code looks in the development package

@develar
Copy link
Member

develar commented Apr 18, 2016

And it is documented in the dev. readme will be fixed, thanks.

@mcfedr
Copy link
Author

mcfedr commented Apr 19, 2016

Seems confusing that the name and description come from the application package, but that homepage and license come from dev.

To me it would make sense to look for everything in application package, maybe even falling back to checking dev package (for backwards compatibility?)

I would be willing to make a pull request if its something that would be considered? Maybe this conversation has been had already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants