Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows on ARM for NSIS (non-web) #4229

Closed
dangeredwolf opened this issue Sep 11, 2019 · 1 comment
Closed

Support Windows on ARM for NSIS (non-web) #4229

dangeredwolf opened this issue Sep 11, 2019 · 1 comment
Labels

Comments

@dangeredwolf
Copy link
Contributor

dangeredwolf commented Sep 11, 2019

  • Version: N/A
  • Target: Windows (arm64)

Currently, the NSIS target does not work with arm64 if you also build for x64 architecture. When it's built, the scripts currently don't differentiate between x64 and arm64, and will overwrite one another when building the NSIS target.

Affiliated pull request: #4228

(requires changes to electron-userland/electron-builder-binaries and some additional testing)

Starting in electron 6.0.8, electron now ships official win/arm64 binaries, so it'd be a good idea to update electron-builder to support it.

@stale
Copy link

stale bot commented Nov 11, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Nov 11, 2019
@stale stale bot closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant