Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS installers built on macOS stopped working in 22.0.0 #4374

Closed
lutzroeder opened this issue Oct 31, 2019 · 1 comment
Closed

NSIS installers built on macOS stopped working in 22.0.0 #4374

lutzroeder opened this issue Oct 31, 2019 · 1 comment

Comments

@lutzroeder
Copy link
Contributor

lutzroeder commented Oct 31, 2019

  • Version: 22.0.0
  • Target: NSIS

After updating from 21.2.0 to 22.0.0 the NSIS installers built on macOS with npx electron-builder --win no longer work. Same installer command run on Windows produces an installer that works. Started happening with the update to nsis 3.0.4 in #4228 in electron-builder 22.0.0.

Repro steps

  1. on macOS unzip electron-builder-4374.zip
  2. npm install
  3. npx electron-builder --win
  4. Copy dist/electron-builder-4374 Setup 1.0.0.exe to Windows machine and run installer
Faulting application name: electron-builder-4374 Setup 1.0.0.exe, version: 1.0.0.0, time stamp: 0x5c157f86
Faulting module name: ntdll.dll, version: 10.0.18362.387, time stamp: 0xa4208572
Exception code: 0xc0000005
Fault offset: 0x000782e5
Faulting process id: 0x1e98
Faulting application start time: 0x01d5920a1d754b87
Faulting application path: electron-builder-4374 Setup 1.0.0.exe
Faulting module path: C:\Windows\SYSTEM32\ntdll.dll
Report Id: 6c6658e7-f283-4535-ad2b-027ff535d389
Faulting package full name: 
Faulting package-relative application ID: 

@dangeredwolf @devlar

@lutzroeder lutzroeder changed the title NSIS installer stopped working NSIS installers built on macOS stopped working Oct 31, 2019
@lutzroeder lutzroeder changed the title NSIS installers built on macOS stopped working NSIS installers built on macOS stopped working in 22.0.0 Nov 4, 2019
@lutzroeder
Copy link
Contributor Author

Fixed in 22.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant