Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store Files #545

Closed
ghost opened this issue Jun 27, 2016 · 9 comments · May be fixed by qcif/data-curator#563
Closed

Ignore .DS_Store Files #545

ghost opened this issue Jun 27, 2016 · 9 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@ghost
Copy link

ghost commented Jun 27, 2016

  • Version: 5.1.0
  • Target: Any

I get some complaints from users that .DS_Store files are in the repo's. Is it possible to ignore these files and not add them somehow? Or is that my responsibility?

@develar
Copy link
Member

develar commented Jun 27, 2016

We don't pack dot files by default. Do you see such files in the your app.asar?

@ghost
Copy link
Author

ghost commented Jun 27, 2016

I presume it comes from the resources folder.

@develar
Copy link
Member

develar commented Jun 27, 2016

So, do you see see such files in the your app.asar? Or where?

@ghost
Copy link
Author

ghost commented Jun 27, 2016

I mean the extraResources specified in package.json.

@develar develar added the bug label Jun 27, 2016
@develar
Copy link
Member

develar commented Jun 27, 2016

How did you specify pattern? Just foo instead of foo/**/* ?

@ghost
Copy link
Author

ghost commented Jun 27, 2016

Just foo

@develar
Copy link
Member

develar commented Jun 27, 2016

Well, specify as foo/**/* ;) Does it help?

@ghost
Copy link
Author

ghost commented Jun 27, 2016

hmm i don't understand that pattern? Why two subfolders deep as that? But ok, will try.

@ghost
Copy link
Author

ghost commented Jun 27, 2016

OK this pattern seems to fix it, why does this work? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant