Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with "contains executable code" #689

Closed
virror opened this issue Aug 22, 2016 · 11 comments · May be fixed by qcif/data-curator#563
Closed

issue with "contains executable code" #689

virror opened this issue Aug 22, 2016 · 11 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@virror
Copy link

virror commented Aug 22, 2016

  • Version: 5.30.0
  • Target: win32

Im trying to use asar to get a dll and a node file as a dependency to my project, but im getting the error: "node_modules\nodeaep is not packed into asar archive - contains executable code"
This worked fine before in 4.x.

Part of the package.json:
"devDependencies": {
"electron-builder": "^5.30.0",
"electron": "^1.3.3"
},
"build": {
"asar.unpack": "/app/{VROOT/, node_modules/*/.+(lua|node|dll)}",
},

@develar
Copy link
Member

develar commented Aug 22, 2016

error: "node_modules\nodeaep is not packed into asar archive - contains executable code"

It is not an error. electron-builder automatically compute correct asar.unpack — you don't need to specify it explicitly.

asar.unpack

If you still want to explicitly set unpack, use asar as object –

"asar": {
  "unpack": "your value"
}

But as far I see electron-builder correctly detects DLLs and unpack it.

@virror
Copy link
Author

virror commented Aug 22, 2016

Thank you for your fast answer!
I changed it to:
"build": {
"asar": {
"unpack": "/app/{VROOT/, node_modules/*/.+(lua|node|dll)}"
},

And i still get the same error : /

@develar
Copy link
Member

develar commented Aug 22, 2016

What error do you mean? " is not packed into asar archive - contains executable code" is not an error and not even a warning — it is just info.

@virror
Copy link
Author

virror commented Aug 22, 2016

True its just info, im sorry i was a bit unclear here. I get this following error message after and i thought it was because of the asar.unpack thing:
"Error: ENOENT: no such file or directory, open 'D:\Source\aep-sdk\electron\dist\win-ia32-unpacked\resources\app.asar.unpacked\node_modules\nodeaep\aep.dll'"
Since thats one of the files that triggers the info.

@develar
Copy link
Member

develar commented Aug 22, 2016

is it possible to share project?

@virror
Copy link
Author

virror commented Aug 22, 2016

Thats not really possible since its a commercial project. I can share whatever information you need though.
Have to ask the boss about sharing actual files : )

@develar
Copy link
Member

develar commented Aug 22, 2016

Have to ask the boss about sharing actual files : )

I think it will be possible to create simple project using only nodeaep dep. But I don't see nodeaep in the npm. Source code is not required for me.

@develar
Copy link
Member

develar commented Aug 22, 2016

If you cannot wait, you can temporary disable asar: "asar": false. I will wait sample project from you to reproduce.

@virror
Copy link
Author

virror commented Aug 22, 2016

Here are a small sample project: --downloaded--
just run: "npm run pack:win" in the electron folder.
I hope thats helps : )

@develar develar added bug and removed question labels Aug 22, 2016
@develar
Copy link
Member

develar commented Aug 22, 2016

@virror Thanks for sample project, fixed.

@virror
Copy link
Author

virror commented Aug 22, 2016

Np, happy to help : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants