fix: support asar in package.json's main
property even when not kaging to asar during the build
#759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the case when the app is packaged to
.asar
earlier than in the process of building with electron-builder.In my case I have the app split into 3 smaller asar archives for some modularity reasons. I have tried with
asar: false
but it failed even though Electron normally supports it. You can provide any path in themain
ofpackage.json
e.g. it could besomePath/some.asar/evenMore/index.js
.I did not create an issue because I went to fixing it immediately. If an issue needs to be filed first, let me know.
In the tests I have added
(custom asar)
to distinguish it from usingasar: true
- not sure if this naming is ok.