Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support asar in package.json's main property even when not kaging to asar during the build #759

Closed
wants to merge 1 commit into from

Conversation

wojtkowiak
Copy link
Contributor

This pull request fixes the case when the app is packaged to .asar earlier than in the process of building with electron-builder.
In my case I have the app split into 3 smaller asar archives for some modularity reasons. I have tried with asar: false but it failed even though Electron normally supports it. You can provide any path in the main of package.json e.g. it could be somePath/some.asar/evenMore/index.js.
I did not create an issue because I went to fixing it immediately. If an issue needs to be filed first, let me know.
In the tests I have added (custom asar) to distinguish it from using asar: true - not sure if this naming is ok.

…kaging to asar during the build

fix the case when the app is packaged to asar before the build process
in this case there might be an asar archive specified in the `main` file path even if the asar options was set to false
@mention-bot
Copy link

@wojtkowiak, thanks for your PR! By analyzing the annotation information on this pull request, we identified @develar, @ha-D and @demetris-manikas to be potential reviewers

@develar develar closed this in d9bc4e0 Sep 19, 2016
@develar
Copy link
Member

develar commented Sep 19, 2016

Binary files (like asar) should be stored using GIT LFS (https://git-lfs.github.com). Committed for you.

Thanks for pull request.

@wojtkowiak
Copy link
Contributor Author

@develar thanks for correcting 😄 and quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants