fix(linter): don't pass --color to linters that don't support it

Add the flag directly to the NPM script call ISSUES CLOSED: electron-userland/electron-forge-templates#48
electron · Sep 10, 2017 · 66354fb · 66354fb
1 parent bb4c787
commit 66354fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/api/lint.js b/src/api/lint.js
@@ -39,9 +39,9 @@ export default async (providedOptions = {}) => {
       throw 'Failed to locate lintable Electron application';
     }
 
-    d('executing "run lint -- --color" in dir:', dir);
+    d('executing "run lint" in dir:', dir);
     try {
-      await yarnOrNpmSpawn(['run', 'lint', '--', '--color'], {
+      await yarnOrNpmSpawn(['run', 'lint'], {
         stdio: process.platform === 'win32' ? 'inherit' : 'pipe',
         cwd: dir,
       });

diff --git a/src/init/init-npm.js b/src/init/init-npm.js
@@ -31,7 +31,7 @@ export default async (dir, lintStyle) => {
         packageJSON.scripts.lint = 'standard';
         break;
       case 'airbnb':
-        packageJSON.scripts.lint = 'eslint src';
+        packageJSON.scripts.lint = 'eslint src --color';
         break;
       default:
         packageJSON.scripts.lint = 'echo "No linting configured"';