nodeIntegration breaks monaco-editor in React

[johnlindquist]

In my app, if I enable:

renderer({
      nodeIntegration: true
    }),

Then after bundling, the monaco-editor causes the React app to completely re-mount and lose all its state.
My best guess is that monaco-editor uses a Worker that detects Electron and fails. It has been almost impossible to debug.

Note: This works fine in npm run dev mode, it only breaks after npm run build then dynamically loading the monaco-editor

Any ideas?

[caoxiemeihao]

kitapp gives some errors when I run it locally, is it possible to provide a simple replication of the Demo, I will focus more on the problems vite-plugin-electron-renderer is facing.

[johnlindquist]

@caoxiemeihao Sorry, I missed this. I'll try to get around to this tomorrow.

I don't need to use the nodeIntegration property, so I stopped investigating for now and switched to working on other things.

Why is nodeIntegration the default? I feel like I'm missing why I would want to use it.

[caoxiemeihao]

Vite does not provide a corresponding Electron pre-config. So nodeIntegration is designed to ensure that Vite builds the Electron-Renderer correctly. It is disabled by default.

  /**
   * @default false
   */
  nodeIntegration?: boolean

https://github.com/electron-vite/vite-plugin-electron-renderer/blob/v0.11.0/src/index.ts#L8-L11