New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change requests with API LGTM appear as both "Approved" and "Requested Changes" #136

Closed

erickzhao opened this issue Mar 16, 2023 · 1 comment

Labels

🪲 bug

Member

erickzhao commented Mar 16, 2023

See https://github.com/electron/electron/pull/37535/checks?check_run_id=12028226514

The original review from @~nornagon was of this format:

Link: electron/electron#37535 (review)

dsanders11 added the 🪲 bug label

Member

itsananderson commented Sep 26, 2024

I think this issue is resolved now, because we don't look at "Requested Changes" for API review state after #163 landed

itsananderson closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment