src: clean up embedder API

nodejs/node#35897
electron · Oct 13, 2022 · 6692559 · 6692559
1 parent e5d39a8
commit 6692559
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/shell/browser/javascript_environment.cc b/shell/browser/javascript_environment.cc
@@ -262,11 +262,11 @@ v8::Isolate* JavascriptEnvironment::Initialize(uv_loop_t* event_loop) {
   auto* tracing_agent = node::CreateAgent();
   auto* tracing_controller = new TracingControllerImpl();
   node::tracing::TraceEventHelper::SetAgent(tracing_agent);
-  platform_ = node::CreatePlatform(
+  platform_ = node::MultiIsolatePlatform::Create(
       base::RecommendedMaxNumberOfThreadsInThreadGroup(3, 8, 0.1, 0),
       tracing_controller, gin::V8Platform::PageAllocator());
 
-  v8::V8::InitializePlatform(platform_);
+  v8::V8::InitializePlatform(platform_.get());
   gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode,
                                  gin::ArrayBufferAllocator::SharedInstance(),
                                  nullptr /* external_reference_table */,

diff --git a/shell/browser/javascript_environment.h b/shell/browser/javascript_environment.h
@@ -32,7 +32,7 @@ class JavascriptEnvironment {
   void OnMessageLoopCreated();
   void OnMessageLoopDestroying();
 
-  node::MultiIsolatePlatform* platform() const { return platform_; }
+  node::MultiIsolatePlatform* platform() const { return platform_.get(); }
   v8::Isolate* isolate() const { return isolate_; }
   v8::Local<v8::Context> context() const {
     return v8::Local<v8::Context>::New(isolate_, context_);
@@ -42,8 +42,7 @@ class JavascriptEnvironment {
 
  private:
   v8::Isolate* Initialize(uv_loop_t* event_loop);
-  // Leaked on exit.
-  node::MultiIsolatePlatform* platform_;
+  std::unique_ptr<node::MultiIsolatePlatform> platform_;
 
   v8::Isolate* isolate_;
   gin::IsolateHolder isolate_holder_;