Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-multi-logger doesn't work #1463

Closed
3 tasks done
issacgerges opened this issue Jan 31, 2020 · 2 comments
Closed
3 tasks done

web-multi-logger doesn't work #1463

issacgerges opened this issue Jan 31, 2020 · 2 comments
Labels

Comments

@issacgerges
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Forge Version:
    • 6.0.0-beta.47
  • Electron Version:
    • v7.1.10
  • Operating System:
    • MacOS 10.15.2
  • Last Known Working Electron Forge version::
    • Any version released prior to the upgrade of xterm to 4.x

Expected Behavior

web-multi-logger works

Actual Behavior

web-multi-logger fails to load, unable to resolve resources mapped under /xterm/*

To Reproduce

Install the latest version of electron-forge from clean, and attempt to view the logger

Additional Information

Looks like this was broken with this PR from dependabot
#1151

xterm did a package restructure and built out a plugin system so we'll need to fixup the way we resolve xterm assets for express and probably add a test validating those assets are present

The following workaround works for folks with yarn

  "resolutions": {
    "@electron-forge/**/xterm": "3.14.5"
  }
@malept
Copy link
Member

malept commented Jan 31, 2020

Sorry about that. This was fixed in #1387 but I'm having computer problems at the moment, so I'm not sure when I can make a new Forge release.

@malept
Copy link
Member

malept commented Feb 3, 2020

I've released beta 48. Thanks for your patience!

@malept malept closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants