Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default platforms: null in forge config "makers" prevents app from starting #2016

Closed
positlabs opened this issue Oct 31, 2020 · 0 comments
Closed
Labels

Comments

@positlabs
Copy link

positlabs commented Oct 31, 2020

Preflight Checklist

  • [x ] I have read the contribution documentation for this project.
  • [x ] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x ] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

I am in the process of migrating from electron-forge v5. After running yarn electron-forge import, npm start fails to start the app and outputs the error below.

  • Electron Forge Version:
    • 6.0.0-beta.54
  • Electron Version:
    • v10.1.5
  • Operating System:
    • MacOS 10.15.7
  • Last Known Working Electron Forge version::
    • 5.x

Expected Behavior

The electron app should start.

Actual Behavior

An unhandled rejection has occurred inside Forge:
TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at proxify (/Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/core/src/util/forge-config.ts:23:35)
    at proxify (/Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/core/src/util/forge-config.ts:25:33)
    at proxify (/Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/core/src/util/forge-config.ts:25:33)
    at proxify (/Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/core/src/util/forge-config.ts:25:33)
    at _default (/Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/core/src/util/forge-config.ts:151:10)
    at _default (/Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/core/src/api/start.ts:37:23)
    at /Users/pixelfiend/workspace/LPLMercury/node_modules/@electron-forge/cli/src/electron-forge-start.ts:58:19

Electron Forge was terminated. Location:
{}

To Reproduce

Set platforms: null in and of the forge config's "makers"

module.exports = {
  "packagerConfig": {
    "icon": "./src/assets/icons/logo-green-icon-1024"
  },
  "makers": [
    {
      "name": "@electron-forge/maker-squirrel",
      "platforms": null
    },
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant