-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@electron-forge/maker-zip
: If using macUpdateManifestBaseUrl
and RELEASES.json
doesn't exist in S3, fails
#3378
Comments
@electron-forge/maker-zip
: If using macUpdateManifestBaseUrl
and RELEASES.json
doesn't exist, fails@electron-forge/maker-zip
: If using macUpdateManifestBaseUrl
and RELEASES.json
doesn't exist in S3, fails
I'm also running into this issue, did you find a way around it @TranquilMarmot ? Edit: looks like I figured it out, I just dropped a RELEASES.json with only |
@spaceandrew if you make an empty |
Thank you! |
Pre-flight checklist
Electron Forge version
6.4.2
Electron version
v26.2.4
Operating system
macOS 13.5.2 (22G91)
Last known working Electron Forge version
No response
Expected behavior
When publishing with
@electron-forge/maker-zip
andmacUpdateManifestBaseUrl
withforge.config.ts
like this:If
https://my-bucket.s3.amazonaws.com/my-app-updates/darwin/${arch}/RELEASES.json
does not yet exist, it should be created.Actual behavior
The publish fails with an error:
I believe this is happening here:
forge/packages/maker/zip/src/MakerZIP.ts
Lines 47 to 51 in 0734b02
await got.get(parsed.toString());
should be wrapped in atry
/catch
and ignore if the file doesn't exist yet in S3.Steps to reproduce
Use
@electron-forge/maker-zip
andmacUpdateManifestBaseUrl
withoutRELEASES.json
existing in S3Additional information
No response
The text was updated successfully, but these errors were encountered: