Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupIcon settings not in effect #3381

Open
3 tasks done
fragransQ opened this issue Oct 14, 2023 · 1 comment
Open
3 tasks done

setupIcon settings not in effect #3381

fragransQ opened this issue Oct 14, 2023 · 1 comment

Comments

@fragransQ
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.4.2

Electron version

27.0.0

Operating system

Windows 11

Last known working Electron Forge version

No response

Expected behavior

Successfully changed setupIcon

Actual behavior

setupIcon settings not in effect

Steps to reproduce

setupIcon settings not in effect, and it still used the default icon. This is my code:
// forge.config.ts const config: ForgeConfig = { packagerConfig: { name: 'Electron App', icon: 'path/to/icon' }, rebuildConfig: {}, makers: [ new MakerSquirrel({ setupIcon: 'path/to/icon.ico' }), new MakerZIP({}, ['darwin']), new MakerRpm({}), new MakerDeb({}) ], ....
When I changed the version number, I was surprised to find that it worked.
But when I changed back to the original version number, it no longer worked, and Setup.exe still used the default icon.

What should I do to change the setupIcon without changing the version number

Additional information

No response

@emekaorji
Copy link

Having this same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants