Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use electron-forge to execute make build, copy the source code to the output directory, and do not use vite to build the compressed js file. #3417

Closed
3 tasks done
xhc-code opened this issue Nov 18, 2023 · 3 comments

Comments

@xhc-code
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.1

Electron version

27.1

Operating system

win10

Last known working Electron Forge version

No response

Expected behavior

使用electron-forge执行make构建,应该只使用vite构建好的文件进行打包exe,然后也不应该复制整个node_modules目录到out目录下。

Actual behavior

I'm using electron27.1 and electron-forge7.1 versions,
But when I run npm run make (the same make command as the electron-vite template), this will cause my entire project to be copied to the root directory out. The following is the path location "out/ruoyi-win32-x64/resources/ app", the code under this app completely contains my source code, and the resource files such as html and js inside have not been compressed by Vite construction. What is going on?

This link seems to have the same problem.
#3224 (comment)

Steps to reproduce

none

Additional information

No response

@akash07k
Copy link

akash07k commented Dec 9, 2023

Yes, I too am facing this same issue. seems that something is really not right

@huangcs427
Copy link

+1

@caoxiemeihao
Copy link
Member

Fixed by #3336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants