Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript ESM forge.config.ts error #3671

Open
3 tasks done
codec-xyz opened this issue Aug 13, 2024 · 7 comments
Open
3 tasks done

Typescript ESM forge.config.ts error #3671

codec-xyz opened this issue Aug 13, 2024 · 7 comments

Comments

@codec-xyz
Copy link

codec-xyz commented Aug 13, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.4.0

Electron version

v31.3.1

Operating system

Windows 11

Last known working Electron Forge version

No response

Expected behavior

To not get an error when using a Typescript ESM forge.config.ts.

Actual behavior

Error are listed under the steps to reproduce section.

Steps to reproduce

Run npm init electron-app@7.4.0 my-new-app -- --template=vite-typescript

Add "type": "module", to package.json

Note

To make other parts of the template work with "type": "module"

In vite.main.config change formats: ['cjs'], to formats: ['es'],

In vite.preload.config change format: 'cjs', to format: 'es',

In src/main.ts change

if (require('electron-squirrel-startup')) {
  app.quit();
}

			↓↓↓

import electronSquirrelStartup from 'electron-squirrel-startup';
if(electronSquirrelStartup) app.quit();

and replace __dirname with import.meta.dirname

You can also npm install --save-dev @types/electron-squirrel-startup and in tsconfig.json change "module": "commonjs","module": "ESNext", to make typescript happy.

Run npm run start

This result in this error...

› Must use import to load ES Module: C:\path\my-new-app\forge.config.ts
  require() of ES modules is not supported.
  require() of C:\path\my-new-app\forge.config.ts from C:\path\my-new-app\node_modules\@electron-forge\core\dist\util\forge-config.js is an ES
  module file as it is a .ts file whose nearest parent package.json contains "type": "module" which defines all .ts
  files in that package scope as ES modules.
  Instead change the requiring code to use import(), or remove "type": "module" from
  C:\path\my-new-app\package.json.

An unhandled rejection has occurred inside Forge:
Error: Must use import to load ES Module: C:\path\my-new-app\forge.config.ts
require() of ES modules is not supported.
require() of C:\path\my-new-app\forge.config.ts from C:\path\my-new-app\node_modules\@electron-forge\core\dist\util\forge-config.js is an ES module file as it is a .ts file whose nearest parent package.json contains "type": "module" which defines all .ts files in that package scope as ES modules.
Instead change the requiring code to use import(), or remove "type": "module" from C:\path\my-new-app\package.json.

However changing forge.config.ts to forge.config.js (and removing the type definitions) makes the error go away. So seemingly JS ES modules work but TS ES modules do not work.

Another option is changing the forge.config.ts to a forge.config.cts but it does not work with "module": "ESNext" (or other ES module options) in the tsconfig.json which gives the error...

  › Cannot use import statement outside a module

Failed to load: C:\path\my-new-app\forge.config.cts

An unhandled rejection has occurred inside Forge:
SyntaxError: Cannot use import statement outside a module

Additional information

No response

@GitMurf
Copy link

GitMurf commented Aug 21, 2024

@codec-xyz I have found the same inconsistent behavior and to be honest I just tried every which combination until something was working for us (but feels very fragile and certainly not ideal long term). For us we went with using forge.config.cts and had to set module: commonjs which is not what we want overall but works for us right now. As you can see by my comments in the screenshot below, we also could not get ESNext to work which is what led us to settling on commonjs.

I believe it is related to:

Screenshot of tsconfig tweaks that finally got it to work for us:

image

@GitMurf
Copy link

GitMurf commented Aug 21, 2024

@codec-xyz I am just glad I am not crazy and that you came to the same conclusion as me! I spent way too many hours (days) trying to figure this out and the imposter syndrome was starting to become real strong for me! haha

@AmbitionsXXXV
Copy link

I also encountered this problem. When I wanted to migrate to ESM according to the latest version of electron-store, I found that forge.config.ts did not support ESM.

@justgo97
Copy link

justgo97 commented Sep 4, 2024

Using the template shared in the issue below worked for me initially, But later I needed to change the preload script output to cjs and moduleResolution to Node because some issues started showing up, Not sure if it was a problem on my end but with those changes everything seem to work fine.

#3502 (comment)

@SRichner
Copy link

SRichner commented Sep 7, 2024

Having the same issue.

@rtritto
Copy link

rtritto commented Sep 21, 2024

This issue should be related to rechoir dependency that currently doesn't support ESM (gulpjs/rechoir#43).

Electron forge v7.5.0 add support with ESM but, for this issue, nothing is changed.

Repro

  • yarn init -y

  • yarn set version berry

  • yarn add -D @electron-forge/cli @electron-forge/plugin-vite electron ts-node typescript vite (note ts-node dependency related to Missing ts-node as optional peer dependency #3609)

  • Create an empty forge.config.ts file

  • yarn electron-forge start

  • Output:

    ✔ Checking your system
    ✔ Locating application
    ✖ Loading configuration
    
      1. Must use import to load ES Module: C:\<PROJECT_PATH>\forge.config.ts
      require() of ES modules is not supported.
      require() of C:\<PROJECT_PATH>\forge.config.ts from
      C:\Users\<USER>\AppData\Local\Yarn\Berry\cache\@electron-forge-core-patch-50fd2dab5c-10c0.zip\node_modules\@electron-forge\core\helper\dynamic-import.js is an  
      ES module file as it is a .ts file whose nearest parent package.json contains "type": "module" which defines all .ts files in that package scope as ES modules.   
      Instead change the requiring code to use import(), or remove "type": "module" from C:\<PROJECT_PATH>\package.json.
    
      2. Unknown file extension ".ts" for C:\<PROJECT_PATH>\forge.config.ts
    ◼ Preparing native dependencies
    ◼ Running generateAssets hook
    
    Failed to load: C:\<PROJECT_PATH>\forge.config.ts
    
    An unhandled rejection has occurred inside Forge:
    Error:
    1. Must use import to load ES Module: C:\<PROJECT_PATH>\forge.config.ts
    require() of ES modules is not supported.
    require() of C:\<PROJECT_PATH>\forge.config.ts from C:\Users\<USER>\AppData\Local\Yarn\Berry\cache\@electron-forge-core-patch-50fd2dab5c-10c0.zip\node_modules\@electron-forge\core\helper\dynamic-import.js is an ES module file as it is a .ts file whose nearest parent package.json contains "type": "module" which defines all .ts files in that package scope as ES modules.
    Instead change the requiring code to use import(), or remove "type": "module" from C:\<PROJECT_PATH>\package.json.
    
    2. Unknown file extension ".ts" for C:\<PROJECT_PATH>\forge.config.ts

Maybe rechoir dependency can be replaced with another dependency (e.g. tsx #3676 (comment)) that support ESM or we can contribute to gulpjs/rechoir#43.

FYI @erickzhao @MarshallOfSound

@rtritto
Copy link

rtritto commented Sep 21, 2024

Related/duplicated/same issues: #3230 #3502 #3608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants