Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default falsy platform/arch to host values #147

Merged
merged 2 commits into from
Feb 22, 2020
Merged

fix: default falsy platform/arch to host values #147

merged 2 commits into from
Feb 22, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 11, 2020 •
edited
Loading

Alternate proposal to #137
Closes #137

Blocked by #141

CC: @dsanders11

@dsanders11
Copy link
Member

@malept, LGTM.

@malept malept changed the base branch from always-transform-arch to master February 11, 2020 23:34
malept and others added 2 commits February 11, 2020 15:37
@malept
fix: default falsy platform/arch to host values
c38561a
@malept @dsanders11
Add test
6ca3b4f 
Co-Authored-By: David Sanders <dsanders11@ucsbalum.com>
@malept malept force-pushed the handle-falsy-platform-arch branch from 00cc2fa to 6ca3b4f Compare February 11, 2020 23:37
@malept malept marked this pull request as ready for review February 11, 2020 23:37
@malept malept requested a review from a team February 21, 2020 21:12
vhashimotoo
vhashimotoo approved these changes Feb 21, 2020
View reviewed changes
Copy link

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@malept malept merged commit 330898b into master Feb 22, 2020
@malept malept deleted the handle-falsy-platform-arch branch February 22, 2020 00:22
@electron-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhashimotoo vhashimotoo vhashimotoo approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malept @dsanders11 @electron-bot @vhashimotoo