feat: support hardcoded checksums #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
approved these changes
Aug 18, 2021
Co-authored-by: Erick Zhao <erick@hotmail.ca>
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
It looks like this caused a regression: https://github.com/electron/electron-packager/runs/3401225023?check_suite_focus=true |
|
This is great, huge thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add the checksums directly to the published NPM package. To do so
@electron/getneeds to be able to take the hardcoded list and pass it to sumchecker. This makes the security chain of our checksumsyarn.lock integrity --> electron npm package --> hardcoded checksums --> remote
electronbinary is validated