-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js 17 headers problem #114
Comments
Thanks for the issue, @matteodisabatino ! This should be fixed in the next release 🙇♀️ |
🎉 This issue has been resolved in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry to bother again but there's something I can't understand: release 3.4.1 contains the fix this issue refers to, that means Node.js version has been switched from 17.0.0 to 17.0.1 but then has been released version 3.5.0 in which version was rolled back to 17.0.0. What happened? 🤔 |
@matteodisabatino The ABI registry is auto generated, manually editing the registry will be reverted within ~30 minutes by our automation. @VerteDinde if there is an issue with the registry we'll need to update the script not the JSON file |
Sorry, Is it possible to have any news? |
@VerteDinde sorry, but... are there any news? The problem still persist... |
In Node.js 17.0.0 an header is missing and this cause the following error during the compilation of a C++ addon.
This was a known problem and was solved in version 17.0.1; so, in order to solve this compilation error, this row should be changed to:
"target": "17.0.1"
.In fact, forcing prebuild to use source of Node.js 17.0.1, the compilation succeeds:
If you want I can provide a pull request.
The text was updated successfully, but these errors were encountered: