feat: add support for pnpm workspace #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsanders11 @erickzhao any reason not to merge this? |
BlackHole1
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
LGTM. Thanks to @seokju-na's PR and @hipstersmoothie's reminder.
PTAL @dsanders11
dsanders11
changed the title
dsanders11
approved these changes
Jan 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
=======================================
Coverage 77.06% 77.06%
=======================================
Files 21 21
Lines 763 763
Branches 142 142
=======================================
Hits 588 588
Misses 122 122
Partials 53 53 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ✋
When using the pnpm workspace, there was a problem that some native modules were missing from the build target because the project root path is incorrect.
This PR adds support for pnpm workspace by find where
pnpm-lock.yamlis located.