Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on node-gyp must be updated #325

Closed
daniel3303 opened this issue Nov 2, 2019 · 2 comments · Fixed by #327
Closed

Dependency on node-gyp must be updated #325

daniel3303 opened this issue Nov 2, 2019 · 2 comments · Fixed by #327

Comments

@daniel3303
Copy link

It seems that electron-rebuild depends on node-gyp v5.0.1 which has a bug for macOS Catalina https://github.com/nodejs/node-gyp/issues/1917. The bug has been fixed for the latest version v6.0.1. This bug prevents users from compiling some packages (not all of them), some examples are node-sqlite3, usb amoung others.

I was able to fix the bug for me simply by updating the dependency on gyp from v5.0.1 to version v6.0.1
@daniel3303 daniel3303 mentioned this issue Nov 2, 2019
Closed
@zpm683
Copy link

zpm683 commented Nov 4, 2019 •
edited
Loading

also have this BUG: node-gyp arm64 node.lib returns HTTP code 403
nodejs/node-gyp#1933

when execute the .\node_modules.bin\electron-rebuild.cmd，bug is coming

@Ciriak Ciriak mentioned this issue Nov 5, 2019
Closed
@malept malept mentioned this issue Nov 6, 2019
Merged
@sregger
Copy link

sregger commented Nov 6, 2019

Delighted to see this is already in progress

@bm-kenji-nakamura bm-kenji-nakamura mentioned this issue Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sregger @zpm683 @daniel3303