Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode does not show suggestions for es6 import style? #65

Closed
Nikki1993 opened this issue Jun 25, 2017 · 4 comments
Closed

VSCode does not show suggestions for es6 import style? #65

Nikki1993 opened this issue Jun 25, 2017 · 4 comments

Comments

@Nikki1993
Copy link

When I write import {} from 'electron' it doesn't give me import suggestions, however if I write is as a standard node module import const {} = require('electron') I get suggestions to import; app, BrowserWindow etc, any guesses where is it going south?

Steps to Reproduce:

  1. Download vscode
  2. Create new project with yarn init
  3. Run yarn install electron
  4. Create new .ts file and try to import electron module and get suggestions about exported modules via import {} from 'electron
@Nikki1993 Nikki1993 changed the title Typescript imports do not show suggestions for es6 import style? VSCode does not show suggestions for es6 import style? Jun 25, 2017
@zeke
Copy link
Contributor

zeke commented Jun 27, 2017

CtrlSpace might help...

screen shot 2017-06-27 at 12 32 37 pm

@Nikki1993
Copy link
Author

Nikki1993 commented Jun 27, 2017

Obviously @zeke but I did that and it doesn't work for me. Even with all extensions disabled, no suggestions have been showed for es6 import style.

I have been able to confirm with at least 1 other person on slack that suggestions weren't thrown, at the very least on 1.13.1 of VSCode.

it lists suggestion only after I typed {app} etc somewhere else in the code but with the fresh project, it never gave me any options.

@mjbvz
Copy link

mjbvz commented Jun 28, 2017

I believe the root cause of this issue is this TS bug, rather than an error in the electron d.ts file. See my comment on the VSCode mirror of this issue for more info: microsoft/vscode#29399 (comment)

@zeke
Copy link
Contributor

zeke commented Jun 28, 2017

Thanks @mjbvz. Closing this out.

@zeke zeke closed this as completed Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants