Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleArchFiles minimatch doesn't work for files in .webpack folder #75

Open
jjeff opened this issue Jul 25, 2023 · 2 comments
Open

singleArchFiles minimatch doesn't work for files in .webpack folder #75

jjeff opened this issue Jul 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jjeff
Copy link

jjeff commented Jul 25, 2023

By default, Webpack puts its files in a folder called .webpack. Then Electron Forge bundles these files into your app package.

However, without the "dot" option, minimatch ignores any files in this "hidden" directory. This means I get errors like the following:

[FAILED] Detected unique file ".webpack/main/index-x64.jsc" in "/var/folders/y2/m0k2q_mn2_jb9tm37k1wds1r0000gn/T/electron-universal-NzIpvm/Tmp.app/Contents/Resources/app.asar" not covered by allowList rule: "**/*.jsc"

I believe this can be fixed by adding dot: true to the minimatch options in checkSingleArch() function in asar-utils.ts.

@jjeff
Copy link
Author

jjeff commented Jul 25, 2023

I've solved my error by switching my rule from **/*.jsc to *.jsc which works because matchBase is enabled in checkSingleArch(). But the above still feels like a bug.

@erickzhao erickzhao added the bug Something isn't working label Jun 12, 2024
@erickzhao
Copy link
Member

I think that'd be functionally identical to {.*,*}/**/*.jsc with dot: false as well. I personally would prefer to keep dot: false since it's the default for minimatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants