Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Typescript for files in entry-asar #83

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Nov 2, 2023

Let's use TS for the files in entry-asar so we don't run into issues like #80 anymore. This also adds the missing imports to entry-asar/no-asar.ts.

@erikian erikian requested a review from a team as a code owner November 2, 2023 19:17
@erikian erikian force-pushed the build/typescript-entry-asar branch 2 times, most recently from 680d0e1 to 7855a81 Compare November 2, 2023 19:27
@erikian erikian changed the title build: use Typescript for files in entry-asar fix: use Typescript for files in entry-asar Nov 2, 2023
@erikian erikian force-pushed the build/typescript-entry-asar branch from 7855a81 to 1d4ef21 Compare November 2, 2023 19:45
@erikian erikian force-pushed the build/typescript-entry-asar branch from 1d4ef21 to cd451fb Compare November 2, 2023 19:46
Copy link
Contributor

@georgexu99 georgexu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most knowledgable about asars but it looks legit

@erikian erikian merged commit 1948f1c into main Nov 2, 2023
3 checks passed
@erikian erikian deleted the build/typescript-entry-asar branch November 2, 2023 22:10
Copy link

🎉 This PR is included in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants