Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump minimum node version to 16 and add tests #86

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

MarshallOfSound
Copy link
Member

BREAKING CHANGE: Bumps minimum node version to node 16

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner November 6, 2023 15:36
@dsanders11
Copy link
Member

@MarshallOfSound, looks like this PR is hitting the same annoyance I hit over on electron/build-tools-installer when moving it to CFA releases. The ugly workaround there was this: https://github.com/electron/build-tools-installer/blob/9a17b4da4eb0adf02e3508f4d2953b82104d0799/package.json#L35-L37

@erickzhao erickzhao marked this pull request as draft November 7, 2023 21:19
@dsanders11 dsanders11 self-assigned this Nov 7, 2023
@MarshallOfSound MarshallOfSound marked this pull request as ready for review November 9, 2023 18:25
@MarshallOfSound MarshallOfSound changed the title build: add tests feat: bump minimum node version to 16 and add tests Nov 9, 2023
@MarshallOfSound MarshallOfSound merged commit 8e2842b into main Nov 9, 2023
7 checks passed
@MarshallOfSound MarshallOfSound deleted the add-tests branch November 9, 2023 18:56
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

MarshallOfSound added a commit that referenced this pull request Nov 9, 2023
MarshallOfSound added a commit that referenced this pull request Nov 9, 2023
BREAKING CHANGE: Minimum node version is now 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants