Skip to content

chore: update prettier 3.6 and use experimental CLI #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsanders11 merged 3 commits into from
Jun 30, 2025
Merged

chore: update prettier 3.6 and use experimental CLI #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a86be1c
chore: update prettier 3.6 and use experimental CLI
erickzhao Jun 27, 2025
742ec27
Merge branch 'main' into prettier-3.6
erickzhao Jun 28, 2025
e3e0986
fix link
erickzhao Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions blog/electron-13-0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ The following APIs have been removed or are now deprecated:
- Deprecated the `new-window` event of `WebContents`. It is replaced by `webContents.setWindowOpenHandler()`
- Removed deprecated `shell.moveItemToTrash()`. [#26723](https://github.com/electron/electron/pull/26723)
- Removed the following deprecated `BrowserWindow` extension APIs:

- `BrowserWindow.addExtension(path)`
- `BrowserWindow.addDevToolsExtension(path)`
- `BrowserWindow.removeExtension(name)`
Expand All @@ -71,19 +70,16 @@ The following APIs have been removed or are now deprecated:
- `BrowserWindow.getDevToolsExtensions()`

Use the `session` APIs instead:

- `ses.loadExtension(path)`
- `ses.removeExtension(extension_id)`
- `ses.getAllExtensions()`

- The following `systemPreferences` methods have been deprecated:

- `systemPreferences.isDarkMode()`
- `systemPreferences.isInvertedColorScheme()`
- `systemPreferences.isHighContrastColorScheme()`

Use the following `nativeTheme` properties instead:

- `nativeTheme.shouldUseDarkColors`
- `nativeTheme.shouldUseInvertedColorScheme`
- `nativeTheme.shouldUseHighContrastColors`
Expand Down
8 changes: 1 addition & 7 deletions blog/introducing-api-history.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ on the fact it is present in a v30.x.x release.
I added a usage/style guide dedicated to writing API history documentation for
new features. I described proper usages of the YAML schema in detail, provided
typical/useful examples, etc. You can find it
[here](https://github.com/electron/electron/blob/main/docs/styleguide.md#api-history).
[here](https://github.com/electron/electron/blob/main/docs/development/style-guide.md#api-history).

### Migration guide

Expand All @@ -179,7 +179,6 @@ manually, on a file-by-file basis,
## Deliverables

- `api-history.schema.json`

- A comprehensive YAML schema for documenting API history which includes support
for:
- [x] Additions
Expand All @@ -192,7 +191,6 @@ manually, on a file-by-file basis,
- [x] Used in: [electron/website#594][website]

- `lint-markdown-api-history.ts`

- Script for linting YAML API history written according to a custom YAML
(technically JSON) schema.
- [x] Useful error messages
Expand All @@ -203,28 +201,24 @@ manually, on a file-by-file basis,
- [x] Used in: [electron/electron#42982][electron]

- `preprocess-api-history.ts`

- Performs simple validation just in case incorrect API History manages to make
it into the repo. Also strips the HTML comment tags that wrap API History blocks
since [Docusaurus](https://docusaurus.io/) cannot parse them.
- [x] Implemented/Used in: [electron/website#594][website]

- `transformers/api-history.ts`

- Script for converting YAML API history blocks in the Markdown documentation files
to ~~Markdown/HTML~~ [React](https://react.dev/) tables (`ApiHistoryTable.tsx`).
- [x] Implemented/Used in: [electron/website#594][website]

- `ApiHistoryTable.tsx`

- React table component used to display parsed API History data on the
documentation website.
- [x] Uses styling that follows the rest of the website's design.
- [x] Responsive, accessible, and generally well written HTML, CSS, and JS.
- [x] Implemented/Used in: [electron/website#594][website]

- `styleguide.md`

- Usage/style guide section for new API history documentation system.
- [x] Easy to understand
- [x] Well written
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"update-l10n-sources": "npx tsx scripts/update-l10n-sources.ts",
"lint:eslint": "eslint \"src/**/*.{js,jsx,ts,tsx}\" \"scripts/**/*.{js,ts}\"",
"lint:markdown": "markdownlint-cli2 \"**/*.md\"",
"lint": "npx tsc --noEmit && prettier . --check && npm run lint:eslint && npm run lint:markdown",
"lint:fix": "prettier . --write && npm run lint:eslint --fix && npm run lint:markdown --fix",
"lint": "npx tsc --noEmit && prettier . --check --experimental-cli && npm run lint:eslint && npm run lint:markdown",
"lint:fix": "prettier . --write --experimental-cli && npm run lint:eslint --fix && npm run lint:markdown --fix",
"pre-build": "npx tsx ./scripts/pre-build.ts",
"prepare": "husky"
},
Expand Down Expand Up @@ -91,7 +91,7 @@
"mdast-util-mdx": "^3.0.0",
"mdast-util-to-hast": "^13.2.0",
"mdast-util-to-string": "^4.0.0",
"prettier": "^3.4.2",
"prettier": "^3.6.2",
"remark": "^15.0.0",
"remark-gfm": "^4.0.0",
"tar-stream": "^2.2.0",
Expand All @@ -113,9 +113,9 @@
]
},
"lint-staged": {
"*.{html,json,md,yml,css,scss}": "prettier --write",
"*.{html,json,md,yml,css,scss}": "prettier --write --experimental-cli",
"*.{js,jsx,ts,tsx}": [
"prettier --write",
"prettier --write --experimental-cli",
"eslint --fix"
]
},
Expand Down
9 changes: 6 additions & 3 deletions src/css/custom.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,18 @@
// infima shadow levels
// generated from https://www.joshwcomeau.com/shadow-palette/
--shadow-color: 0deg 0% 63%;
--shadow-elevation-low: 0px 1px 1px hsl(var(--shadow-color) / 0.07),
--shadow-elevation-low:
0px 1px 1px hsl(var(--shadow-color) / 0.07),
0px 1.4px 1.4px -1.8px hsl(var(--shadow-color) / 0.06),
-0.1px 3px 2.9px -3.5px hsl(var(--shadow-color) / 0.04);
--shadow-elevation-medium: 0px 1px 1px hsl(var(--shadow-color) / 0.06),
--shadow-elevation-medium:
0px 1px 1px hsl(var(--shadow-color) / 0.06),
0px 1.8px 1.7px -0.9px hsl(var(--shadow-color) / 0.05),
-0.1px 3.5px 3.4px -1.8px hsl(var(--shadow-color) / 0.05),
-0.1px 7.5px 7.3px -2.7px hsl(var(--shadow-color) / 0.04),
-0.3px 15px 14.5px -3.5px hsl(var(--shadow-color) / 0.03);
--shadow-elevation-high: 0px 1px 1px hsl(var(--shadow-color) / 0.06),
--shadow-elevation-high:
0px 1px 1px hsl(var(--shadow-color) / 0.06),
0px 2.1px 2px -0.4px hsl(var(--shadow-color) / 0.05),
-0.1px 3.4px 3.3px -0.8px hsl(var(--shadow-color) / 0.05),
-0.1px 5.2px 5px -1.2px hsl(var(--shadow-color) / 0.05),
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12224,10 +12224,10 @@ prettier-linter-helpers@^1.0.0:
dependencies:
fast-diff "^1.1.2"

prettier@^3.4.2:
version "3.4.2"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.4.2.tgz#a5ce1fb522a588bf2b78ca44c6e6fe5aa5a2b13f"
integrity sha512-e9MewbtFo+Fevyuxn/4rrcDAaq0IYxPGLvObpQjiZBMAzB9IGmzlnG9RZy3FFas+eBMu2vA0CszMeduow5dIuQ==
prettier@^3.6.2:
version "3.6.2"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.6.2.tgz#ccda02a1003ebbb2bfda6f83a074978f608b9393"
integrity sha512-I7AIg5boAr5R0FFtJ6rCfD+LFsWHp81dolrFD8S79U9tb8Az2nGrJncnMSnys+bpQJfRUzqs9hnA81OAA3hCuQ==

pretty-error@^4.0.0:
version "4.0.0"
Expand Down