Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring : séparer les controlleurs admin & membres #879

Open
6 of 9 tasks
raphodn opened this issue Jun 5, 2023 · 0 comments · Fixed by #875, #878, #959, #962 or #966
Open
6 of 9 tasks

Refactoring : séparer les controlleurs admin & membres #879

raphodn opened this issue Jun 5, 2023 · 0 comments · Fixed by #875, #878, #959, #962 or #966

Comments

@raphodn
Copy link
Member

raphodn commented Jun 5, 2023 •
edited
Loading

Quoi ?

Certains controlleurs gèrent à la fois des vues "membres", et des vues "admin".
Or la route est définie à la racine du controlleur, donc généralement les vues "admin" ne sont alors pas précédées de /admin.

C'est le cas par exemple de PeriodController

L'idée est donc de séparer en 2. Dans l'exemple : PeriodController & AdminPeriodController

Controlleurs concernés par le split

  • PeriodController
  • EventController & EventKindController
  • OpeningHourController & OpeningHourKindController
  • ClosingExceptionController
  • BookingController
  • ShiftController ?

Autres controlleurs (prefixer de Admin)
@raphodn raphodn linked a pull request Jun 5, 2023 that will close this issue
Refactoring : séparer EventController & AdminEventController #875
Merged
@raphodn raphodn linked a pull request Jun 6, 2023 that will close this issue
Refactoring : séparer PeriodController & AdminPeriodController #878
Merged
This was linked to pull requests Aug 22, 2023
Refactoring : séparer OpeningHourController et AdminOpeningHourController #959
Merged
Refactoring : renommer EventKindController en AdminEventKindController #962
Merged
Refactoring : renommer ClosingExceptionController en AdminClosingExceptionController #966
Merged
This was linked to pull requests Sep 30, 2023
Refactoring : renommer MembershipShiftExemptionController en AdminMembershipShiftExemptionController #1022
Merged
Refactoring : renommer ShiftExemptionController en AdminShiftExemptionController #1023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring : séparer EventController & AdminEventController elefan-grenoble/gestion-compte
Refactoring : séparer PeriodController & AdminPeriodController elefan-grenoble/gestion-compte
Refactoring : séparer OpeningHourController et AdminOpeningHourController elefan-grenoble/gestion-compte
Refactoring : renommer EventKindController en AdminEventKindController elefan-grenoble/gestion-compte
Refactoring : renommer ClosingExceptionController en AdminClosingExceptionController elefan-grenoble/gestion-compte
Refactoring : renommer MembershipShiftExemptionController en AdminMembershipShiftExemptionController elefan-grenoble/gestion-compte
Refactoring : renommer ShiftExemptionController en AdminShiftExemptionController elefan-grenoble/gestion-compte
1 participant
@raphodn