Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvatarStack doesn't allow non-avatar elements in the stack #215

Closed
t3chguy opened this issue Sep 4, 2023 · 2 comments
Closed

AvatarStack doesn't allow non-avatar elements in the stack #215

t3chguy opened this issue Sep 4, 2023 · 2 comments
Assignees

Comments

@t3chguy
Copy link
Member

t3chguy commented Sep 4, 2023

Element Web's FacePile looks like this:

image

It has an extra overflow tile "..." at the end which follows the stacking behaviour. Due to the styling of compound-web the style is not applied and it ends up not being stacked.

image

image

Either relax the selector or export the class/wrapper element to allow stacking things other than Compound avatars to enable wider reuse. Otherwise code ends up having to work around it and duplicate logic which can de-sync:

image

Partly caused element-hq/element-web#26112

@Johennes
Copy link

Johennes commented Sep 5, 2023

Once this is done, we should also clean up the temporary workaround made in matrix-org/matrix-react-sdk#11527.

@t3chguy
Copy link
Member Author

t3chguy commented Nov 17, 2023

This was fixed by @germain-gg

@t3chguy t3chguy closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants