Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spaces] / Read Only MVP Phase 1 #2495

Closed
25 of 28 tasks
BillCarsonFr opened this issue Dec 7, 2020 · 5 comments · Fixed by #2840
Closed
25 of 28 tasks

[Spaces] / Read Only MVP Phase 1 #2495

BillCarsonFr opened this issue Dec 7, 2020 · 5 comments · Fixed by #2840
Assignees
Labels
A-Spaces Spaces, groups, communities matrix-sdk

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Dec 7, 2020

See matrix-org/matrix-spec-proposals#1772
and room types matrix-org/matrix-spec-proposals#1840

-> Basic support for spaces. As a user I should be able to receive an invite, preview the space content and join (or discard invite). Support leave.

SDK

  • Database
    • persist room type
    • New SpaceSummaryEntity
    • Database migration  
  • Create Space Service
    • Create Space
    • Get Space from Id
    • Peek Space from id or alias
      - [ ] Detect/Protect from space subspace cycle
    • Get space summary (detached + live)
    • Join Space (and default rooms of that space)
  • Space Model
    • Add room to space
    • Remove room
    • Add subspace
    • Set child as default / add order
  • Support room type (messaging / space)

UI

  • Debug commands to create space / add child
  • Add Lab flag in settings to enable space feature
  • Show user spaces in left drawer (invites + member)
  • Click on invite to open space preview
    • Add Space Preview Activity / fragments / model
    • 0 depth support
    • subspace display support (simple max depth)
    • Join Space
      - [ ] Discard Invite
      - [ ] Manage edge cases (failed to peek?)
      ~~ - [ ] Integrate new Space API for preview~~
  • Handle current space selection
    • filter visible rooms
    • filter visible DM
    • Update home toolbar
    • [ ] Notification badge
    • [ ] Handle All spaces case
  • [ ] New FAB buttons behaviour
    • [ ] In room tab should open explore space rooms screen
    • [ ]~~ In DM tab, modify a bit existing screen to display footer 'Looking for someone outside of ? Switch space or Invite them'~~

Issues

  • [ ] Only show root spaces on left drawer (avoid to have both parent and child at same level)
@BillCarsonFr BillCarsonFr added matrix-sdk delight A-Spaces Spaces, groups, communities labels Dec 7, 2020
@BillCarsonFr BillCarsonFr self-assigned this Dec 7, 2020
@BillCarsonFr BillCarsonFr changed the title [Spaces] / SDK support for Spaces [Spaces] / Read Only MVP Phase 1 Jan 5, 2021
@progserega
Copy link

progserega commented Jan 16, 2021

Hello!
Standart use case for users: create group of his contacts. It is create personal group, with not show anybody. But...
But I try create private space on https://riots.im/adhoc/spaces3 and can not simply add my private chats to this space... I can add only room or invite users. After invate users - they must join to my PRIVATE space. What is this?! What changes from community?!
Why you do not create simply grouping of private chats and rooms. I want simply have private "groups":

  1. work
  2. home
  3. friends

Why my friends need join to my private spaces?! I do not understand...

@t3chguy
Copy link
Member

t3chguy commented Feb 10, 2021

can not simply add my private chats to this space

This is a feature which simply has not had UX designed for it but is planned.

@progserega
Copy link

This is a feature which simply has not had UX designed for it but is planned.

I hope this is will be accepted. 👍

@heyakyra
Copy link

ℹ️ All existing communities will die instead of be migrated:

Which phase one covers migration of existing groups/communities to spaces?

None.

element-hq/element-web#15930 (comment)

@t3chguy
Copy link
Member

t3chguy commented Apr 16, 2021

They won't die, the newer clients will just lose the ability to access them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities matrix-sdk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants