Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle room upgrades within Spaces #4133

Closed
BillCarsonFr opened this issue Oct 1, 2021 · 1 comment · Fixed by #6200
Closed

Better handle room upgrades within Spaces #4133

BillCarsonFr opened this issue Oct 1, 2021 · 1 comment · Fixed by #6200
Assignees
@ericdecanini
Labels
A-Room-Upgrades A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Oct 1, 2021 •
edited
Loading

Steps to reproduce

Reflect web changes element-hq/element-web#19246

Your use case

The client should resolve upgrades locally where possible to deduplicate space listings
@BillCarsonFr BillCarsonFr added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Spaces Spaces, groups, communities labels Oct 1, 2021
@BillCarsonFr BillCarsonFr self-assigned this Oct 1, 2021
@kittykat kittykat added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-Upgrades labels Jan 14, 2022
@ericdecanini ericdecanini self-assigned this Apr 15, 2022
@ericdecanini
Copy link
Contributor

@BillCarsonFr I've done some investigating and testing on this issue and my question is do we still need to action this?

On testing, there's no situation where a listing is duplicated. When a room is upgraded and an old member is not invited to the upgraded room, they may see the old room in their room list that they can go into and see that it is upgraded. This seems to be normal behaviour. This happens thanks to receiving a tombstone state event from the server on upgrade.

The moment they get an invite to the new room, the old room's listing disappears and gets replaced by the invite.

@ericdecanini ericdecanini mentioned this issue May 31, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericdecanini ericdecanini

Labels
A-Room-Upgrades A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes room not being in space after upgrade element-hq/element-android
3 participants
@kittykat @BillCarsonFr @ericdecanini