WIP and low priority: upgrade konfetti to 2.0.2 #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
bmarty
force-pushed
the
feature/bma/konfetti2
branch
2 times, most recently
from
596efb0 to
dc6e280
Compare
bmarty
commented
Feb 22, 2022
bmarty
changed the title
Does not compile
bmarty
force-pushed
the
feature/bma/konfetti2
branch
from
5f490b8 to
a089947
Compare
bmarty
commented
Apr 4, 2022
| timeToLive = 2000L, | ||
| position = Position.Relative(0.0, 0.0).between(Position.Relative(1.0, 0.0)), | ||
| ) | ||
| reset() |
There was a problem hiding this comment.
calling reset() fixes the issue when displaying the confetti several times (in the timeline)
|
onboarding confetti still works and looks better IMO! 👍
I now see what you mean about the confetti falling behind the text/icon |
ouchadam
approved these changes
Apr 4, 2022
|
(I have added a changelog, no need for a full CI build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Konfetti to the latest version
Compilation warning is now fixed, probably due to the update of library Jitsi.
The rendering is not strictly equivalent, but still acceptable to me.
We are using the "rain" party, but we could choose a different configuration, from the sample app:
Also reporting that on the celebration screen (after account creation), the confetti are displayed below the other views, which is a bit strange to me, and not equivalent to what we have in the timeline. This PR does not change that.