Fix endless loading timeline if opened at non-existing event #5659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Büttner dev@spiritcroc.de
Type of change
Content
Pass M_NOT_FOUND and M_FORBIDDEN server errors to timeline listeners.
Motivation and context
When opening a permalink for a non-existing event (e.g. the event has been deleted on the server), or a forbidden event (e.g. after a moderator redacted the event), we want to tell the user the event wasn't found, and instead reload the timeline without initial eventId. Before, it was just loading endlessly without any indication of a reason.
Tests
Create a permalink for a room with changing the eventId to something like "$doesntexist", and click it.
Tested devices
Checklist