Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PR process doc with 2 reviewers and a new reviewer team #5836

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Apr 25, 2022

We are going to have 2 reviewers per PR to improve the review quality.

@manuroe manuroe force-pushed the feature/manu/pr-2-reviews branch from 34bc5da to 1b387c8 Compare April 25, 2022 16:20
@manuroe manuroe changed the title Update pull_request.md with 2 reviewers and a new reviewer team Update the PR process doc with 2 reviewers and a new reviewer team Apr 25, 2022
@manuroe manuroe requested review from bmarty, a team and ganfra and removed request for a team April 25, 2022 16:21
@github-actions
Copy link

Unit Test Results

114 files  ±0  114 suites  ±0   1m 24s ⏱️ -9s
202 tests ±0  202 ✔️ ±0  0 💤 ±0  0 ±0 
678 runs  ±0  678 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 1b387c8. ± Comparison against base commit a521824.

@ouchadam
Copy link
Contributor

FWIW buildkite failed due to a dependency related network issue

* What went wrong:
--
  | A problem occurred configuring root project 'workdir'.
  | > Could not resolve all files for configuration ':classpath'.
  | > Could not download commons-collections-3.2.2.jar (commons-collections:commons-collections:3.2.2)
  | > Could not get resource 'https://plugins.gradle.org/m2/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar'.
  | > Could not GET 'https://repo.gradle.org/artifactory/jcenter/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar'. Received status code 409 from server: Conflict

@manuroe manuroe merged commit f5973fa into develop Apr 27, 2022
@manuroe manuroe deleted the feature/manu/pr-2-reviews branch April 27, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants