Space list crash fix #5924
Merged
Space list crash fix #5924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added
the
Z-NextRelease
bmarty
requested review from
a team,
onurays and
ouchadam
and removed request for
a team
|
Maybe the correct fix is to filter space invites here: https://github.com/vector-im/element-android/blob/cf532550d079b02a6ec9e49d83886836bc99f0a1/vector/src/main/java/im/vector/app/features/spaces/SpaceSummaryController.kt#L144 They are maybe displayed twice. |
ouchadam
approved these changes
May 4, 2022
ouchadam
reviewed
May 4, 2022
| @@ -117,7 +123,7 @@ class SpaceSummaryController @Inject constructor( | |||
| ?.forEach { roomSummary -> | |||
| spaceSummaryItem { | |||
| avatarRenderer(host.avatarRenderer) | |||
| id(roomSummary.roomId) | |||
| id("invite_${roomSummary.roomId}") | |||
There was a problem hiding this comment.
a unique id for the invite makes sense to me to fix the crash, we can iterate on the proper UX (whether two spaces with the same id should be present in the spaces list...)
bmarty
force-pushed
the
feature/bma/space_fix
branch
from
cf53255 to
70c1310
Compare
ouchadam
reviewed
May 4, 2022
| @@ -135,41 +141,42 @@ class SpaceSummaryController @Inject constructor( | |||
| } | |||
|
|
|||
| rootSpaces | |||
| ?.forEach { groupSummary -> | |||
| val isSelected = selected is RoomGroupingMethod.BySpace && groupSummary.roomId == selected.space()?.roomId | |||
| ?.filter { it.membership != Membership.INVITE } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Try to fix https://github.com/matrix-org/element-android-rageshakes/issues/37765 :
According to the log, this is a space invite. We may have a race condition, where an invite is displayed for a space which is already joined? So displayed twice and the Epoxy item has the same ID. This PR adds a prefix for the space invitation items.
Also space invite will be filtered out from the space root list. This is probably the only required fix, but keeping the previous fix on the
iddoes not hurt.Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist