Cleanup of #5187 #6326
Merged
Cleanup of #5187 #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested review from
a team,
Claire1817 and
mnaturel
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
mnaturel
reviewed
Jun 17, 2022
| @@ -102,8 +102,9 @@ class RoomWidgetPermissionBottomSheet : | |||
| } | |||
|
|
|||
| override fun onCancel(dialog: DialogInterface) { | |||
| viewModel.handle(RoomWidgetPermissionActions.BlockWidget) | |||
There was a problem hiding this comment.
Maybe we should reuse the existing doDecline method?
There was a problem hiding this comment.
I see. It is up to you but we could create a sub method without including call to dismiss() as you suggested?
mnaturel
approved these changes
Jun 17, 2022
Claire1817
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5187 for more details.
Will squash and merge to cleanup git history.
After my change:
Fixes #5114