Expose pusher profile tag in advanced settings #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <johannesm@element.io>
Johennes
force-pushed
the
johannes/expose-profile-tag
branch
from
a27e3e7 to
ec07355
Compare
Johennes
requested review from
a team,
onurays and
bmarty
and removed request for
a team
ouchadam
reviewed
Jun 23, 2022
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginBottom="16dp" | ||
| android:textStyle="" /> |
There was a problem hiding this comment.
the empty text style is a little strange, would have expected normal instead of blank or removing the tag entirely, might be worth cleaning up the file whilst we're in the area 🙏
There was a problem hiding this comment.
I toggled the text style property to bold and back to nothing selected in Android Studio and it looks like that just removes the textStyle properties altogether. Committed and pushed that change. Is that alright?
There was a problem hiding this comment.
yep, that's great! I'm a little surprised that the blank case had been compiling
ouchadam
approved these changes
Jun 23, 2022
Signed-off-by: Johannes Marbach <johannesm@element.io>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This makes the current pusher's profile tag visible in the advanced settings.
Motivation and context
For debugging notifications, it's helpful to know the profile tag.
Screenshots / GIFs
Tests
Navigate into Settings > Advanced Settings > Notification Targets
Tested devices
Checklist