Share location with other apps (PSG-242) #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
changed the title
onurays
requested review from
a team and
Claire1817
and removed request for
a team
Claire1817
reviewed
Jul 19, 2022
| isFocusable = true | ||
| isTouchable = true | ||
| elevation = 8f | ||
| setBackgroundDrawable(ContextCompat.getDrawable(context, R.drawable.bg_live_location_marker_popup)) |
There was a problem hiding this comment.
Can you add the background directly in the view_live_location_marker_popup.xml file ?
There was a problem hiding this comment.
It works, thanks, done.
| inputMethodMode = INPUT_METHOD_NOT_NEEDED | ||
| isFocusable = true | ||
| isTouchable = true | ||
| elevation = 8f |
There was a problem hiding this comment.
the same for the elevation ? add it directly in the xml file ?
| var callback: Callback? = null | ||
|
|
||
| init { | ||
| contentView = inflater.inflate(R.layout.view_live_location_marker_popup, null, false) |
There was a problem hiding this comment.
i have a warning on Android Studio:
Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)
|
|
||
| fun show(anchorView: View) { | ||
| contentView.measure(View.MeasureSpec.UNSPECIFIED, View.MeasureSpec.UNSPECIFIED) | ||
| showAsDropDown(anchorView, -contentView.measuredWidth / 2, 0) |
There was a problem hiding this comment.
Maybe add a comment to explain the:
-contentView.measuredWidth / 2
|
Thanks @Claire1817 for reporting bugs related to marker rendering when the user doesn't have an avatar. #6594 will be fixed in another PR. |
Claire1817
approved these changes
Jul 19, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Users can now open others' (or their own) live locations with other map applications by tapping the marker of the users. Shared location is the static location at the time users click to share button.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist