Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space Switching: Space Invites #6924

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Space Switching: Space Invites #6924

merged 6 commits into from
Aug 30, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Aug 24, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds invites to space list

Motivation and context

Closes #6583

Screenshots / GIFs

Light Dark Black

Tests

  • Be invited to a space (without accepting the invitation)
  • Open the space list and see the invite at the bottom
  • Click on the invite and see that you can respond to the invite

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini marked this pull request as ready for review August 24, 2022 10:43
@ericdecanini ericdecanini requested review from a team, ganfra and fedrunov and removed request for a team August 24, 2022 10:43
ganfra
ganfra reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks

vector/src/main/java/im/vector/app/features/spaces/NewSpaceSummaryController.kt Outdated
@@ -51,6 +52,7 @@ class NewSpaceSummaryController @Inject constructor(
nonNullViewState.spaces,
nonNullViewState.selectedSpace,
nonNullViewState.rootSpacesOrdered,
nonNullViewState.inviters,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass the nonNullViewState instead of each values?

vector/src/main/java/im/vector/app/features/home/room/list/UnreadCounterBadgeView.kt Outdated
@@ -44,6 +44,13 @@ class UnreadCounterBadgeView : MaterialTextView {
}
}

fun renderWithText(text: String, highlighted: Boolean) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to have one render method with sealed class State instead

Base automatically changed from feature/eric/accordion-bottom-sheet to develop August 26, 2022 12:04
@ericdecanini ericdecanini requested a review from ganfra August 26, 2022 13:06
ganfra
ganfra approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM

@ericdecanini
Fixes lint errors
24202db
@ericdecanini
Merge remote-tracking branch 'origin/develop' into feature/eric/space…
0025b66 
…-invites

# Conflicts:
#	vector/src/main/java/im/vector/app/features/spaces/NewSpaceSummaryController.kt
@ElementBot
Copy link

Warnings
⚠️

vector/src/main/java/im/vector/app/features/home/room/list/SectionHeaderAdapter.kt#L55 - It will always be more efficient to use more specific change events if you can. Rely on notifyDataSetChanged as a last resort.
⚠️

vector/src/main/java/im/vector/app/features/home/room/list/SectionHeaderAdapter.kt#L55 - It will always be more efficient to use more specific change events if you can. Rely on notifyDataSetChanged as a last resort.
⚠️

vector/src/main/res/layout/item_space_invite.xml#L11 - Attribute android:foreground has no effect on API levels lower than 23 (current min is 21)
⚠️

vector/src/main/res/layout/item_space_invite.xml#L11 - Attribute android:foreground has no effect on API levels lower than 23 (current min is 21)

Generated by 🚫 dangerJS against 0025b66

@ericdecanini
Copy link
Contributor Author

As I will be away for the next week, @fedrunov please feel free to merge once approved

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

7.8% 7.8% Coverage
1.3% 1.3% Duplication

@fedrunov fedrunov merged commit b0fb1f9 into develop Aug 30, 2022
@fedrunov fedrunov deleted the feature/eric/space-invites branch August 30, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

@fedrunov fedrunov Awaiting requested review from fedrunov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space Switching: Space Invites
4 participants
@ericdecanini @ElementBot @ganfra @fedrunov