Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Layout: Bottom sheet padding missing (and landscape mode issue) #7027

Closed
daniellekirkwood opened this issue Sep 6, 2022 · 2 comments · Fixed by #7103
Closed

App Layout: Bottom sheet padding missing (and landscape mode issue) #7027

daniellekirkwood opened this issue Sep 6, 2022 · 2 comments · Fixed by #7103
Assignees
@ericdecanini @amshakal
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-AppLayout

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Sep 6, 2022 •
edited
Loading

Steps to reproduce

When I open the bottom sheet there's no padding above all chats, it looks unpolished

Also, when in landscape mode the bottom sheet only shows all chats

In product In figma
ima_915cfc3 Screenshot 2022-09-06 at 10 03 35

image
@daniellekirkwood daniellekirkwood added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-AppLayout labels Sep 6, 2022
@ericdecanini
Copy link
Contributor

Looking back at the designs, it looks like what we want to do is add back the "CHANGE SPACE" header. I'm not sure where but I recall a decision was made a little while ago to remove this.

@amshakal can you confirm this please

@amshakal
Copy link

amshakal commented Sep 6, 2022

Yeah, we should add a simple header (non clickable) saying 'Change Space'. it'll make this sheet look polished

@daniellekirkwood daniellekirkwood added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 6, 2022
@ericdecanini ericdecanini mentioned this issue Sep 6, 2022
Merged
15 tasks
@ericdecanini ericdecanini reopened this Sep 12, 2022
@ericdecanini ericdecanini mentioned this issue Sep 12, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericdecanini ericdecanini

@amshakal amshakal

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[New Layout] Adds peek height (min height) to new layout bottom sheets element-hq/element-android
3 participants
@ericdecanini @amshakal @daniellekirkwood