Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture doc #7126

Merged
merged 10 commits into from
Sep 22, 2022
Merged

Architecture doc #7126

merged 10 commits into from
Sep 22, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 14, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : documentation

Content

Add a documentation to the project with the overall architecture and some entry points to other documentation and third party documentation.

rendered

As a bonus, add support to /devtools command.

Motivation and context

Help new comers to start working on the project.

Screenshots / GIFs

Tests

  • try the new /devtools command

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from amitkma and ganfra September 14, 2022 16:15
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats very helpful, thanks.
Just one small remark on the Event point!


`Events` are item of a Room, where data is embedded.

There are 2 types of Event:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd more write:
There are 2 types of room Event:
State Events:....
Regular Events:...

You can also have event sent outside of a room, like AccountData

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, updated.

@bmarty bmarty merged commit f4c5cba into develop Sep 22, 2022
@bmarty bmarty deleted the feature/bma/arch_doc branch September 22, 2022 14:41
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ElementBot
Copy link

Warnings
⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt#L1127 - Prefer "SHOW_AS_ACTION_IF_ROOM" instead of "SHOW_AS_ACTION_ALWAYS"

⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt#L1127 - Prefer "SHOW_AS_ACTION_IF_ROOM" instead of "SHOW_AS_ACTION_ALWAYS"

Generated by 🚫 dangerJS against 828413c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants