-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Broadcast - Update seek bar position while playing #7496
Voice Broadcast - Update seek bar position while playing #7496
Conversation
a236467
to
53d020c
Compare
53d020c
to
c128bbd
Compare
|
ecacb53
to
e53987b
Compare
e53987b
to
c1dd660
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The code looks good and it seems to work perfectly, sorry for the delay in the review.
Type of change
Content
Update the live position of the playback when the voice broadcast is in a playing state.
Plus some improvements on the voice broadcast player.
Motivation and context
Continue #7127 and improve #7494
Screenshots / GIFs
Tests
Play an ended / live voice broadcast and observe the seekbar behaviour
Tested devices
Checklist