Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast - Update seek bar position while playing #7496

Merged
merged 28 commits into from
Nov 10, 2022

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Oct 31, 2022

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

Update the live position of the playback when the voice broadcast is in a playing state.
Plus some improvements on the voice broadcast player.

Motivation and context

Continue #7127 and improve #7494

Screenshots / GIFs

Ended VB Live VB
https://user-images.githubusercontent.com/11990514/200355744-69dea59f-3b0a-48ab-9c41-ca4ced2fbc52.mp4 https://user-images.githubusercontent.com/11990514/200355809-5139985f-b764-48ee-bc7a-9c605f971ef7.mp4 (the duration of the chunks has been set to 5 sec for this demo)

Tests

Play an ended / live voice broadcast and observe the seekbar behaviour

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 requested review from a team and jonnyandrew and removed request for a team October 31, 2022 18:00
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_seek_to_live_update branch 3 times, most recently from a236467 to 53d020c Compare November 2, 2022 16:07
Base automatically changed from feature/fre/voice_broadcast_seek_to to develop November 2, 2022 22:31
@Florian14 Florian14 requested review from a team and onurays and removed request for jonnyandrew, a team and onurays November 3, 2022 08:14
@Florian14 Florian14 marked this pull request as draft November 3, 2022 11:11
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_seek_to_live_update branch from 53d020c to c128bbd Compare November 7, 2022 10:48
@ElementBot
Copy link

ElementBot commented Nov 7, 2022

Warnings
⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L111 - Custom view AudioWaveformView has setOnTouchListener called on it but does not override performClick

⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L111 - Custom view AudioWaveformView has setOnTouchListener called on it but does not override performClick

⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L111 - onTouch lambda should call View#performClick when a click is detected

⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L111 - onTouch lambda should call View#performClick when a click is detected

Generated by 🚫 dangerJS against c1dd660

@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_seek_to_live_update branch from ecacb53 to e53987b Compare November 7, 2022 14:35
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_seek_to_live_update branch from e53987b to c1dd660 Compare November 7, 2022 15:54
@Florian14 Florian14 requested review from a team and jmartinesp and removed request for a team November 7, 2022 16:02
@Florian14 Florian14 marked this pull request as ready for review November 7, 2022 16:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

2.4% 2.4% Coverage
0.0% 0.0% Duplication

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The code looks good and it seems to work perfectly, sorry for the delay in the review.

@Florian14 Florian14 merged commit 271fd05 into develop Nov 10, 2022
@Florian14 Florian14 deleted the feature/fre/voice_broadcast_seek_to_live_update branch November 10, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants