Fix usage of unknown shield in room summary (PSG-1019)

[onurays]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

While we are developing new Session Management screens we introduced a new shield for devices which has an unknown e2e status. But this also accidentally effected the shield of rooms. This PR will revert these changes.

Motivation and context

Screenshots / GIFs

Tests

• Login with an unverified session
• Enable new session management in Labs settings
• Navigate to Settings > Security & Privacy > Show All Sessions
• See unknown shield ("?") for the current session
• Navigate to an encrypted room details
• See black shield next to the room name instead of an unknown shield

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ElementBot]

	Fails
🚫	node failed.

Log

Error:  Error: Could not find the Dangerfile at tools/danger/dangerfile-lint.js - does a file exist at dangerfile-lint.js in tools/danger?.
    at /usr/src/danger/distribution/platforms/GitHub.js:166:27
    at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
    at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-77a114bb.json

Generated by 🚫 dangerJS against 32ded28

[mnaturel]

There is a missing View to update with the render method for device: SessionInfoView. Otherwise LGTM, thanks for the fix!

[onurays]

There is a missing View to update with the render method for device: SessionInfoView. Otherwise LGTM, thanks for the fix!

Nice catch, done, thank you.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication