Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalinks to a matrix user should be pills #8220

Closed
giomfo opened this issue Mar 7, 2023 · 1 comment
Closed

Permalinks to a matrix user should be pills #8220

giomfo opened this issue Mar 7, 2023 · 1 comment
Assignees
@yostyle
Labels
A-Pills T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Mar 7, 2023 •
edited
Loading

Steps to reproduce

Send in a room the following permalink : "https://matrix.to/#/@sddfshfjkashfk:matrix.org"

Outcome

What did you expect?

a pill with the user's name and profile picture if any. Like this: Screenshot 2023-02-21 at 18 09 52
If this is not possible, the pill should show the default user icon and the mxId : image

What happened instead?

The matrix.to url is displayed
image

Will you send logs?

No

Are you willing to provide a PR?

Yes
@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 7, 2023
@giomfo giomfo mentioned this issue Mar 7, 2023
Closed
12 tasks
@giomfo giomfo added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely and removed S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 7, 2023
@giomfo giomfo added the A-Pills label Mar 7, 2023
@yostyle yostyle mentioned this issue Mar 16, 2023
Merged
15 tasks
@giomfo
Copy link
Member Author

giomfo commented Mar 22, 2023

Done in next release (> v1.5.28)

@giomfo giomfo closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yostyle yostyle

Labels
A-Pills T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yostyle @giomfo