Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--tileWidth and --tileHeight for PiP mode are not defined on develop.element.io #1081

Closed
luixxiul opened this issue May 27, 2023 · 0 comments · Fixed by #1104
Closed

--tileWidth and --tileHeight for PiP mode are not defined on develop.element.io #1081

luixxiul opened this issue May 27, 2023 · 0 comments · Fixed by #1104
Assignees
@robintown
Labels
A-Embedded Using the app embedded within other Matrix clients O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Start Element Call on a room at develop.element.io
  2. Move to another room to have PiP widget displayed

Outcome

What did you expect?

The custom property --AvatarSize should be defined.

What happened instead?

It was not defined as --tileWidth and --tileHeight were not set, which seems to be a cause of element-hq/element-web#24601.

0

Operating system

Debian

Browser information

Firefox

URL for webapp

develop.element.io

Will you send logs?

No
@luixxiul luixxiul added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label May 27, 2023
@robintown robintown self-assigned this Jun 12, 2023
@robintown robintown mentioned this issue Jun 12, 2023
Merged
@robintown robintown added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Embedded Using the app embedded within other Matrix clients labels Jun 12, 2023
@robintown robintown moved this from Incoming to Triaged in Element Call issue triage Jun 12, 2023
@github-project-automation github-project-automation bot moved this from Triaged to Closed in Element Call issue triage Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robintown robintown

Labels
A-Embedded Using the app embedded within other Matrix clients O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple video grid from video tile components robintown/element-call
2 participants
@luixxiul @robintown