Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put ghost participants behind a developer flag #2508

Open
robintown opened this issue Jul 25, 2024 · 1 comment
Open

Put ghost participants behind a developer flag #2508

robintown opened this issue Jul 25, 2024 · 1 comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@robintown
Copy link
Member

Your use case

What would you like to do?

Hide ghost participants by default, and show them only if a developer flag is enabled.

Why would you like to do it?

Ghosts can show up in normal usage of the app whenever there is a delay between someone leaving the call in Matrix and leaving the call in LiveKit. This is not great, as people will generally not know or care about what the 👻 icon means. I contend that ghost participants are really meant to be a developer feature used for load testing.

How would you like to achieve it?

Wait until we get an E2EE system which selectively shares keys with connected participants via a private channel (i.e. to-device messages). We need to wait for this because currently, showing ghost participants is how we prevent eavesdropping.

Have you considered any alternatives?

No response

Additional context

No response

@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 25, 2024
@schelmo
Copy link

schelmo commented Jul 26, 2024

it would be great to have some kind of allowlist for livekit identities.
because the cool thing now is, you can send media to element call rooms (of course only if you have api access to your livekit server) e.g. with the livekit-cli .
these participants are currently also marked as [👻]. i assume these would also be hidden then?
maybe we can define an allowlist in the EC config.json?

{
  "livekit": {
    "livekit_service_url": "https://...",
    "allowed-identities": {
      "my-fancy-video-bot": "<some name here>"
    }
  }
}

maybe the name can also be taken from the livekit participant via the livekit js sdk, and the allowed-identities value can just be an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

2 participants