Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muting audio no longer turns off audio capture. #2568

Closed
ara4n opened this issue Aug 16, 2024 · 2 comments
Closed

Muting audio no longer turns off audio capture. #2568

ara4n opened this issue Aug 16, 2024 · 2 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@ara4n
Copy link
Member

ara4n commented Aug 16, 2024

Steps to reproduce

  1. Press the mute button
  2. See that the webapp is still capturing audio - e.g. on macOS/iOS:
    Screenshot 2024-08-16 at 10 36 55
  3. Worry whether the mute button is actually working or not.
  4. I /think/ we used to stop capturing audio while muted, to be more reassuring?

This is fairly low priority, but am flagging it more because it's slightly surprising me.

Outcome

What did you expect?

Audio should not be captured when you are muted.

What happened instead?

App keeps capturing audio despite being muted.

Operating system

macOS

Browser information

Chrome 127

URL for webapp

call.element.io

Will you send logs?

No

@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Aug 16, 2024
@robintown
Copy link
Member

There probably was a point back in the full mesh era when this behavior was different, but I believe we've been forcing the microphone track on for about a year now. The reason is here in this comment:

// livekit (by default) keeps the mic track open when you mute, but if you start muted,
// doesn't publish it until you unmute. We want to publish it from the start so we're
// always capturing audio: it helps keep bluetooth headsets in the right mode and
// mobile browsers to know we're doing a call.

For example I think I remember that keeping the microphone track is what enables iOS to keep the call going when the browser is backgrounded. As a sanity check I just went through Zoom, Teams, Discord, and Jitsi, and it appears that all of them but Jitsi exhibit this same behavior when you mute. The Web platform just doesn't give us a better way to separate the intent to potentially share audio from whether audio actually gets captured, at the moment.

@toger5
Copy link
Contributor

toger5 commented Oct 8, 2024

As robin describes this a behavior we intentionally decided to fix various issues:

  • bluetooth devices disconnecting
  • webkit backgrounding
    ...
    So we close this issue.

@toger5 toger5 closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants