Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript strict mode #558

Closed
Tracked by #407
dbkr opened this issue Aug 30, 2022 · 4 comments · Fixed by #584
Closed
Tracked by #407

Typescript strict mode #558

dbkr opened this issue Aug 30, 2022 · 4 comments · Fixed by #584
Labels
A-Developer-Experience Workflow of developing: building, linting, debugging, profiling, etc. T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@dbkr
Copy link
Member

dbkr commented Aug 30, 2022

Your use case

We should try to enable typescript's strict mode on the EC codebase ASAP before writing too much new code. We can copy element-web's new strict-mode CI check.

Have you considered any alternatives?

No response

Additional context

No response
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 30, 2022
@SimonBrandner
Copy link
Contributor

I think it might not work due to js-sdk not passing strict checks... Though I agree we should steal the EW CI at the very least

@robintown robintown added the A-Developer-Experience Workflow of developing: building, linting, debugging, profiling, etc. label Aug 30, 2022
@robintown
Copy link
Member

We may be able to use https://github.com/allegro/typescript-strict-plugin to make this less painful (and work around the js-sdk not being strict)

@dbkr
Copy link
Member Author

dbkr commented Sep 15, 2022

Conclusion on looking at this is:

Dave
so if we just installed the plugin, we'd get strict mode errors in the IDE but it would still compile fine?
Robin
yes actually
Dave
and then we can also turn off the IDE errors per-file by adding that comment

...so as far as I'm concerned this sounds ideal

@robintown
Copy link
Member

Will create a PR, then

@robintown robintown mentioned this issue Sep 15, 2022
Merged
@fkwp fkwp mentioned this issue Oct 13, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience Workflow of developing: building, linting, debugging, profiling, etc. T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable strict mode checks with typescript-strict-plugin robintown/element-call
3 participants
@dbkr @SimonBrandner @robintown