Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user suggestion when inviting users to a room, as on web #5050

Closed
jakewb-b opened this issue Oct 26, 2021 · 2 comments
Closed

Implement user suggestion when inviting users to a room, as on web #5050

jakewb-b opened this issue Oct 26, 2021 · 2 comments
Assignees
Labels
A-Invitations O-Occasional Affects or can be seen by some users regularly or most users rarely P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action. Z-PS-Request

Comments

@jakewb-b
Copy link

On Element Web, when inviting users to a room, I see a short list of users I have recently DMd, and then a list of other suggested users.

This is much more user-friendly than the experience on iOS, where by default I see my local contacts (most of whom are not on Matrix) and have to search for users by their Matrix ID.

Can we implement Eleweb’s smart handling of suggested people to invite in a room on iOS?

@jakewb-b jakewb-b added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action. S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Invitations labels Oct 26, 2021
@giomfo
Copy link
Member

giomfo commented Aug 1, 2022

I decided to reuse this issue to start working on element-hq/element-meta#83

Because the same contacts picker is used to create a new DM or to invite users to a room, I would like to consider separately the 2 kinds of suggestion:

  • short list of users I have recently DMd: this suggestion should appeared only when the end user wants to invite users to an existing room. I consider irrelevant on web this short list in case of a new DM creation. Note: this short list doesn't exist in Element-Android.
    We (@jakewb-b, @gaelledel and I) agreed to create dedicated issues to add "this short list of users I have recently DMd" in Element-iOS and in Element-Android, and keep using this one to add the list of suggested/known users.
  • list of "known users": I use here on purpose the wording of Element-Android for this second list. I think this is more relevant than "suggestions"
    The plan would be to implement in Element-iOS the following design:

image

About this design:

  • @gaelledel: what do you think about "known users"? do you prefer to keep "Suggested"? I let you decide
    • this point is still under discussion
  • How to manage the "Local Contacts" which appears when the end user grants access to their phonebook?

image

Don't you think we should merge the matrix user discovered in the phone book in the suggested list and ignore the local contacts who don't match with a matrix account?

In the current suggested design, this list of local contacts is accessible via the icon displayed at the top right corner. This button displays a list of actions which correspond to the curent Android options
image

About the search:
When the end user starts searching, the application is filtering the suggested/known users by considering their display name and/or their matrixId. Note the search on matrixId should be optional in the implementation (some fork of Element don't want to display matrixId). A new section is added to display the result of the search in the users directory. The suggested design is:
image

Note:

  • 1st section “Suggested” shows results based on shared spaces and rooms
  • 2nd section “user directory” shows results based on the whole directory
  • The results should only be reflecting to the begining of a word with from the Display name or matrix ID
  • If a contact was already shown in the “suggested” section, it should not appear in the user directory

@giomfo giomfo added X-Needs-Design May require input from the design team P1 labels Aug 4, 2022
@giomfo giomfo self-assigned this Aug 24, 2022
@rufuskahler rufuskahler removed the X-Needs-Design May require input from the design team label Jan 24, 2023
@rufuskahler
Copy link

Removing 'Needs-Design' as will be resolved through EX work.

@giomfo giomfo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invitations O-Occasional Affects or can be seen by some users regularly or most users rarely P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action. Z-PS-Request
Projects
None yet
Development

No branches or pull requests

4 participants